Skip to content

fix: use quoted full-text search instead of field-specific SLS query …#152

Merged
rsonghuster merged 1 commit intomasterfrom
fix/sls-fulltext-query-syntax
May 5, 2026
Merged

fix: use quoted full-text search instead of field-specific SLS query …#152
rsonghuster merged 1 commit intomasterfrom
fix/sls-fulltext-query-syntax

Conversation

@rsonghuster
Copy link
Copy Markdown
Contributor

@rsonghuster rsonghuster commented May 5, 2026 •
edited by coderabbitai Bot
Loading

…syntax

Field-specific SLS syntax (e.g. requestId: "value") requires key-value index configuration which FC3's default logstore doesn't have, causing "key (requestId) is not config as key value config" errors. Switch to quoted full-text search ("value") which works with the default full-text index configuration.

Change-Id: If44111b49fc8bcb9ad6663497f18fa40248106ae
Co-developed-by: Claude noreply@anthropic.com

Summary by CodeRabbit

  • Improvements

    • Updated SLS query syntax formatting for log queries.
    • Version incremented to 0.1.20.

  • Style

    • Changed match highlighting display from yellow background to reverse-video styling for improved readability.

@rsonghuster
fix: use quoted full-text search instead of field-specific SLS query …
9e365ff 
…syntax

Field-specific SLS syntax (e.g. requestId: "value") requires key-value
index configuration which FC3's default logstore doesn't have, causing
"key (requestId) is not config as key value config" errors. Switch to
quoted full-text search ("value") which works with the default full-text
index configuration.

Change-Id: If44111b49fc8bcb9ad6663497f18fa40248106ae
Co-developed-by: Claude <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 5, 2026 •
edited
Loading

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 96d3057d-2dbc-452e-ba2a-a26b9cfe24dc

📥 Commits

Reviewing files that changed from the base of the PR and between 2b98125 and 9e365ff.

📒 Files selected for processing (3)
  • __tests__/ut/commands/logs_test.ts
  • publish.yaml
  • src/subCommands/logs/index.ts
📝 Walkthrough

Walkthrough

The PR updates the SLS query construction in the logs command to use bare quoted terms for qualifier, instanceId, and requestId parameters instead of field-specific predicates. It also changes match highlighting from yellow background to reverse-video styling. Tests and version metadata are updated accordingly.

Changes

Logs Query Syntax and Styling Update

Layer / File(s) Summary
Core Implementation
src/subCommands/logs/index.ts		 Query parameters (qualifier, instanceId, requestId) are now appended as bare quoted terms (e.g., and "LATEST") instead of field-labeled predicates. Match highlighting changed from yellow background (\x1B[43m) to reverse-video (\x1B[7m) ANSI styling.
Test Expectations
__tests__/ut/commands/logs_test.ts		 Updated getSlsQuery test expectations to match new query syntax: qualifiers and identifiers now appear as quoted terms rather than field-specific expressions.
Version Metadata
publish.yaml		 Component version incremented from 0.1.19 to 0.1.20.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

  • devsapp/fc3#151: Modifies the same getSlsQuery logic and test file, but implements conflicting SLS query syntax changes that enforce field-specific predicates rather than bare quoted terms.

Poem

🐰 A query dressed in quoted terms so clean,
No field labels cluttering the scene!
Reverse-video highlights match with flair,
Version bumped—fresh changes in the air! ✨

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/sls-fulltext-query-syntax

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rsonghuster rsonghuster merged commit 9b644ed into master May 5, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@rsonghuster